-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: first pass at cypress e2e tests #985
Conversation
ca9518c
to
8e84f39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope some of these comments are useful. Also your editor seems to not be linting/auto-fixing automatically?
@benjie it does not, but the pre-push hook took care of this. There are a bunch of linting/prettier fixes that need to be added in a seperate PR it looks like. |
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
=======================================
Coverage 43.14% 43.14%
=======================================
Files 64 64
Lines 2934 2934
Branches 635 635
=======================================
Hits 1266 1266
Misses 1400 1400
Partials 268 268 Continue to review full report at Codecov.
|
5cb70f8
to
c93e007
Compare
d9cdf8f
to
88b6e40
Compare
Some of these files were stubbed out by cypress, thinking of maybe adding some more tests as well, wanted to see how it runs in travis :D